Switch to dfinity/setup-dfx action #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes our local `setup-dfx` action and replaces it with the one maintained by the SDK team. This action has the advantage that it integrates with the new `dfxvm` and reads the desired dfx version from `dfx.json`. Adding the version there also aligns the dfx version used locally with the one on CI. The dfx version will be bumped to `0.18.0` in a follow-up commit. Side-note on CI runtime: the `dfinity/setup-dfx` does not use caching (unlike our version) but still takes only about 4s to complete. Given that we get rid of some complexity that way, I think the 3s are worth it. Also, because the `dfinity/setup-dfx` action is not yet properly published on the market place (there is an open issue for that [here](dfinity/setup-dfx#8)) a specific commit is pinned instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our local
setup-dfxaction and replaces it with the one maintained by the SDK team. This action has the advantage that it integrates with the newdfxvmand reads the desired dfx version fromdfx.json.Adding the version there also aligns the dfx version used locally with the one on CI. The dfx version will be bumped to
0.18.0in a follow-up PR.Side-note on CI runtime: the
dfinity/setup-dfxdoes not use caching (unlike our version) but still takes only about 4s to complete. Given that we get rid of some complexity that way, I think the 3s are worth it.Also, because the
dfinity/setup-dfxaction is not yet properly published on the market place (there is an open issue for that here) a specific commit is pinned instead.