Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate stable memory back-ups to v9 #2368

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Mar 15, 2024

This PR migrates all the stable memory back-ups to storage layout v9 in preparation for removing support for v8.


🟡 Some screens were changed

This PR migrates all the stable memory back-ups to storage layout `v9`
in preparation for removing support for `v8`.

/// Tests that II will refuse to upgrade on stable memory without persistent state.
#[test]
fn should_trap_on_missing_persistent_state() -> Result<(), CallError> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v9 persistent state exists by definition. Hence a back-up without one can no longer be created.

Copy link
Collaborator

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 9a552ae Mar 18, 2024
63 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/migrate-stable-mem-backups-v9 branch March 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants