Remove II's direct dependency on identity.rs library for handling VCs #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikrothenberger
approved these changes
Mar 25, 2024
src/vc_util/src/lib.rs
Outdated
| Ok(encoder.into_jws(sig)) | ||
| } | ||
|
|
||
| /// Extracts the canister signature public key from the given signing_input. |
There was a problem hiding this comment.
Maybe expand the comment a bit on what signing input is? I.e. a JWT without signature.
przydatek
commented
Mar 25, 2024
src/vc_util/src/lib.rs
Outdated
| Ok(encoder.into_jws(sig)) | ||
| } | ||
|
|
||
| /// Extracts the canister signature public key from the given signing_input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now II's code was depending on a fork of
identity.rsin two ways: directly, to create id-alias VCs, and indirectly, via the dependency onvc_util-crate. This PR removes the first (direct) dependency, by extendingvc_util, and changing the format of the id-alias VCs, to follow the recommended convention for general VCs. This completes the removal of direct dependency onidentity.rsfor II and VC-issuers -- now the dependency is encapsulated invc_util-crate.NOTE: a side-effect of this PR is that once it is deployed in production, II will start issuing id-alias VCs in the new format, so any dapp that verifies these VCs should be updated as well. If a dapp is using
vc_utilto verify these VCs, it should be re-compiled with the updated version ofvc_util.🟡 Some screens were changed