Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serving of well-known assets that don't have extensions #2398

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

przydatek
Copy link
Collaborator

@przydatek przydatek commented Apr 2, 2024

asset_util requires that served files do have extensions (so that the files' type & encoding can be established). However, some special, well-known files by definition have no extensions, so to enable serving such files, a "white-list" of known files is added.


🟡 Some screens were changed

@przydatek przydatek marked this pull request as ready for review April 2, 2024 13:37
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@przydatek przydatek added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit f4cfba3 Apr 2, 2024
65 checks passed
@przydatek przydatek deleted the bartosz/serve-well-known-files branch April 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants