Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error when parsing origin for canister id resolution #2404

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Handle error when parsing origin for canister id resolution #2404

merged 1 commit into from
Apr 4, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Apr 4, 2024 •
edited by github-actions bot
Loading

This PR improves error handling when passing invalid origins for canister id resolution.

@frederikrothenberger
Handle error when parsing origin for canister id resolution
e7f5d17 
This PR improves error handling when passing invalid origins for
canister id resolution.
lmuntaner
lmuntaner approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 4bd242a Apr 4, 2024
65 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/catch-url-parse branch April 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikrothenberger @lmuntaner