Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notice msg from VC flow error page #2430

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Apr 15, 2024

Main motivation is to remove the message: "We will now let the relying party know there was an issue." from the error page of the verifiable credentials flow.

This change was requested by product as a quick fix of the error page. The error page will be further improved in another initiative.


🟡 Some screens were changed

@lmuntaner lmuntaner marked this pull request as ready for review April 15, 2024 08:02
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lmuntaner lmuntaner added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 14c1e44 Apr 16, 2024
65 checks passed
@lmuntaner lmuntaner deleted the 04-15-remove_notice_msg_from_vc_flow_error_page branch April 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants