Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure up to 10 retries on agent failure #2447

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Apr 26, 2024

This PR configures the number of retries to 10 (as opposed to just 3, which is the default). This makes the agent more resilient against watermark check failures, because the likelihood of hitting only replicas that are behind gets lowered a lot and retrying takes time too.

Addresses this comment.


🟡 Some screens were changed

This PR configures the number of retries to 10 (as opposed to just
3, which is the default). This makes the agent more resilient
against watermark check failures, because the likelihood of hitting
only replicas that are behind gets lowered a lot and retrying takes time
too.

Addresses [this comment](#2446 (comment)).
@frederikrothenberger frederikrothenberger changed the title Configure up to 10 retries on agnet failure Configure up to 10 retries on agent failure Apr 26, 2024
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 1417991 Apr 26, 2024
65 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/increase-retry-times branch April 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants