Implement automatic event pruning #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds automatic event pruning using timers and self-calls (to enable retries on failure). In normal operation automatic event pruning should not be needed. However, if II stops processing `prepare_delegation` canister calls for some reason for an extended period of time then the backlog of events that need pruning will grow. To make sure that II can process this backlog, `PruneEvents` are injected if the latest event is older than 5 minutes. If the backlog is too large to be processed in a single canister call, then II will fall back to smaller time windows until it becomes processable.
lmuntaner
approved these changes
May 7, 2024
frederikrothenberger
added a commit
that referenced
this pull request
May 8, 2024
A bug was introduced in #2460 that did not correctly restart timers after an upgrade. This PR simplifies the initialization to share more code and adds a test to catch this bug in the future.
frederikrothenberger
added a commit
that referenced
this pull request
May 8, 2024
A bug was introduced in #2460 that did not correctly restart timers after an upgrade. This PR simplifies the initialization to share more code and adds a test to catch this bug in the future.
frederikrothenberger
added a commit
that referenced
this pull request
May 8, 2024
A bug was introduced in #2460 that did not correctly restart timers after an upgrade. This PR simplifies the initialization to share more code and adds a test to catch this bug in the future.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Simplify II init A bug was introduced in #2460 that did not correctly restart timers after an upgrade. This PR simplifies the initialization to share more code and adds a test to catch this bug in the future. * Assert expected state before upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic event pruning using timers and self-calls (to enable retries on failure).
In normal operation automatic event pruning should not be needed. However, if II stops processing
prepare_delegationcanister calls for some reason for an extended period of time then the backlog of events that need pruning will grow.To make sure that II can process this backlog,
PruneEventsare injected if the latest event is older than 5 minutes. If the backlog is too large to be processed in a single canister call, then II will fall back to smaller time windows until it becomes processable.