Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace assert with warning #2488

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Jun 3, 2024

This replaces another consistency check with a warning, such that II would continues to operate if there are duplicate keys for some reason.

This replaces another consistency check with a warning, such that II
would continues to operate if there are duplicate keys for some reason.
Copy link
Collaborator

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 0aed4b8 Jun 3, 2024
65 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/warn-duplicate branch June 3, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants