Add explicit bound to amortized clean-up #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an explicit limit to the number of events processed during amortized clean-up. Using that, we can (in a future PR) remove the timer based mechanism for pruning data.
frederikrothenberger
force-pushed
the
frederik/limit-amortized-work
branch
from
07b8ecd
to
267d13e
Compare
lmuntaner
reviewed
Jun 4, 2024
Since the underlying event data is not deleted, the word "prune" is misleading in the context. It is replaced with "remove from aggregation".
frederikrothenberger
added a commit
that referenced
this pull request
Jun 5, 2024
This removes the timer based pruning that is no longer needed due to #2489. The prune event aggregations will be removed once II reports their value to be 0 (i.e. in a subsequent release after the next one).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Remove timer-based pruning This removes the timer based pruning that is no longer needed due to #2489. The prune event aggregations will be removed once II reports their value to be 0 (i.e. in a subsequent release after the next one). * 🤖 npm run generate auto-update --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit limit to the number of events processed during amortized clean-up (100 events per time window). If more than 100 events need to be cleaned up, then the next call that adds an event will continue where the previous one left off.
Using that, we can (in a future PR) remove the timer based mechanism for pruning data.
🟡 Some screens were changed