Add to vc-issuer a default root key, guard configure() #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikrothenberger
approved these changes
Jun 5, 2024
frederikrothenberger
added a commit
that referenced
this pull request
Jun 7, 2024
In #2493 a guard was introduced on the dummy issuer to only allow configure to be called by controllers. Because the current mainnet deployment of the dummy issuer is only controlled by the wallet `cvthj-wyaaa-aaaad-aaaaq-cai`, this PR extends the provision script to optionally allow making the configure call through the wallet.
frederikrothenberger
added a commit
that referenced
this pull request
Jun 7, 2024
In #2493 a guard was introduced on the dummy issuer to only allow configure to be called by controllers. Because the current mainnet deployment of the dummy issuer is only controlled by the wallet `cvthj-wyaaa-aaaad-aaaaq-cai`, this PR extends the provision script to optionally allow making the configure call through the wallet.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
In #2493 a guard was introduced on the dummy issuer to only allow configure to be called by controllers. Because the current mainnet deployment of the dummy issuer is only controlled by the wallet `cvthj-wyaaa-aaaad-aaaaq-cai`, this PR extends the provision script to optionally allow making the configure call through the wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the demo VC issuer to use the mainnet IC root public key by default, and guard
configure()endpoint, so that only canister controller(s) can change the configuration.🟡 Some screens were changed