Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to provision dummy issuer with wallet #2500

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Jun 7, 2024

In #2493 a guard was introduced on the dummy issuer to only allow configure to be called by controllers.
Because the current mainnet deployment of the dummy issuer is only controlled by the wallet cvthj-wyaaa-aaaad-aaaaq-cai, this PR extends the provision script to optionally allow making the configure call through the wallet.


🟡 Some screens were changed

In #2493 a guard was introduced on the dummy issuer to only allow
configure to be called by controllers.
Because the current mainnet deployment of the dummy issuer is only
controlled by the wallet `cvthj-wyaaa-aaaad-aaaaq-cai`, this PR extends
the provision script to optionally allow making the configure call
through the wallet.
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 8d2edeb Jun 7, 2024
65 checks passed
@frederikrothenberger frederikrothenberger deleted the frederik/use-wallet-to-configure branch June 7, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants