Only allow the most recently used identity to be auto-selected #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an enhancement to the auto-selection feature introduced in #2563: In order to not confuse users, only the most recently used identity can be auto-selected (i.e. when refreshing sessions). This way, a dapp cannot make a user _switch_ identities without them having the identity selected explicitly.
lmuntaner
approved these changes
Aug 29, 2024
| <button @click=${() => useExistingProps.register()} class="t-link"> | ||
| <button | ||
| @click=${() => useExistingProps.register()} | ||
| id="registerButton" |
There was a problem hiding this comment.
I added the id there so that the e2e test button click logic for the register button works the same regardless of the template (firstTime / useExisting).
| ); | ||
| vi.useFakeTimers().setSystemTime(new Date(0)); | ||
| await setKnownPrincipal({ | ||
| userNumber: BigInt(10000), |
There was a problem hiding this comment.
Can we put BitInt(10000) and BigInt(1000) in variables to better read the expectations?
| }) | ||
| ); | ||
|
|
||
| test( |
There was a problem hiding this comment.
Could you add a test adding the principal in another origin?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to the auto-selection feature introduced in #2563: In order to not confuse users, only the most recently used identity can be auto-selected (i.e. when refreshing sessions). This way, a dapp cannot make a user switch identities without them having the identity selected explicitly.