Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dapps list #2596

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Update dapps list #2596

merged 2 commits into from
Sep 9, 2024

Conversation

gix-bot
Copy link
Contributor

@gix-bot gix-bot commented Sep 7, 2024

Automated changes by create-pull-request GitHub action


🟡 Some screens were changed

@gix-bot gix-bot requested a review from a team as a code owner September 7, 2024 00:22
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frederikrothenberger What do you look for in these PRs? Is there a reason not to approve them sometimes?

@frederikrothenberger
Copy link
Member

@lmuntaner: This is more of a sanity check. The actual review should have been done when merging the logos / description in the portal repo (where we pull the information from).

There is one thing that is important though: We allow .svg images, which could be used as an attack vector. So for SVGs we need to make sure that they do not contain malicious content.

@frederikrothenberger frederikrothenberger added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit a4d2846 Sep 9, 2024
66 checks passed
@frederikrothenberger frederikrothenberger deleted the bot-dapps-update branch September 9, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants