No longer reject on unknown messages #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to unify the authorize authentication screen introduced a bug where Internet Identity would fail on unexpected messages. This change fixes this issue.
* Add Rust canister tests This adds some simple rust canister tests (install, upgrade/downgrade). Eventually these tests will completely replace the Haskell tests. Rare are the Haskellers among us these days. This includes a few changes: * The types definitions for types used in the II interface were moved to a new crate, `internet_identity_interface`, which is used by both the main crate and the new canister tests, * The canister tests are implemented in a new crate, `canister_tests`, that only contains test code. Building it without `--tests` is a no-op, * The `cargo-tests` workflow was moved to the `canister-tests` workflow because it needs the built II Wasm module. * Add more useful error messages
frederikrothenberger
force-pushed
the
frederik/fix-reject
branch
from
2428a16
to
8445f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where Internet Identity would fail to load correctly, if sent additional malformed window post messages.