-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authentication mobile styles #674
Update authentication mobile styles #674
Conversation
…com/dfinity/internet-identity into update-authentication-mobile-styles
I just did a demo deployment of your PR here: |
Updated the demo deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, now the padding seems off in desktop view. See changes to screenshots/25-authenticate-unknown-anchor-desktop.png
and screenshots/24-authenticate-known-anchor-desktop.png
…com/dfinity/internet-identity into update-authentication-mobile-styles
|
Updated the demo deployment again. |
And add a new logo, correct? |
In the first iteration we made sure that the space for the extra button was already present to avoid things jumping around. Was the behavior changed on purpose? Screen.Recording.2022-06-13.at.12.35.12.mov |
It was definitely intentional for the error message. Imho, if everything still fits on a single screen when keeping the space for the |
So I'm guessing it didn't fit? |
Motivation
Update authentication page styles to display more info on mobile
Screenshots
pixel
samsung S8+
Iphone 12 pro
Iphone SE