Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authentication mobile styles #674

Merged
merged 19 commits into from
Jun 13, 2022

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Update authentication page styles to display more info on mobile

Screenshots

pixel

localhost_8080_(Pixel 5)

samsung S8+

localhost_8080_(Samsung Galaxy S8+)

Iphone 12 pro

localhost_8080_(iPhone 12 Pro)

Iphone SE

localhost_8080_(iPhone SE)

@mstrasinskis mstrasinskis requested a review from a team as a code owner June 9, 2022 16:06
@frederikrothenberger
Copy link
Member

I just did a demo deployment of your PR here:
• Demo App: https://6zm7l-dyaaa-aaaaa-qaaka-cai.identity.dfinity.network/
• II: https://6cjdo-zaaaa-aaaaa-qaaiq-cai.identity.dfinity.network/

@frederikrothenberger
Copy link
Member

frederikrothenberger commented Jun 10, 2022

Updated the demo deployment

Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, now the padding seems off in desktop view. See changes to screenshots/25-authenticate-unknown-anchor-desktop.png and screenshots/24-authenticate-known-anchor-desktop.png

@mstrasinskis
Copy link
Contributor Author

Unfortunately, now the padding seems off in desktop view. See changes to screenshots/25-authenticate-unknown-anchor-desktop.png and screenshots/24-authenticate-known-anchor-desktop.png
Fixed

@frederikrothenberger
Copy link
Member

Updated the demo deployment again.

@nmattia
Copy link
Collaborator

nmattia commented Jun 13, 2022

Update authentication page styles to display more info on mobile

And add a new logo, correct?

@nmattia
Copy link
Collaborator

nmattia commented Jun 13, 2022

In the first iteration we made sure that the space for the extra button was already present to avoid things jumping around. Was the behavior changed on purpose?

Screen.Recording.2022-06-13.at.12.35.12.mov

@frederikrothenberger
Copy link
Member

In the first iteration we made sure that the space for the extra button was already present to avoid things jumping around. Was the behavior changed on purpose?

It was definitely intentional for the error message.

Imho, if everything still fits on a single screen when keeping the space for the register button, we should revert to reserving the space there again.

@frederikrothenberger frederikrothenberger merged commit 2111ce4 into main Jun 13, 2022
@frederikrothenberger frederikrothenberger deleted the update-authentication-mobile-styles branch June 13, 2022 13:09
@nmattia
Copy link
Collaborator

nmattia commented Jun 13, 2022

if everything still fits on a single screen when keeping the space for the register button, we should revert to reserving the space there again.

So I'm guessing it didn't fit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants