Adds rust tests for the registration flow #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The registration flow consistes of two canister calls: create_challenge and register. As part of testing these canister calls the inteface of api::create_challenge has been changed to return a Result<Challenge, CallError> to make error behaviour testable. Related to registration, this PR includes tests related to the intialization of the user range (ported from haskell). The test for the user range widening has been moved to the http test module (together with other metrics) since it is unrelated to user registration.
frederikrothenberger
force-pushed
the
frederik/rust-register-tests
branch
from
6e826b3
to
8987932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration flow consistes of two canister calls: create_challenge and register.
As part of testing these canister calls the inteface of api::create_challenge has been changed to return a
Result<Challenge, CallError>to make error behaviour testable.Related to registration, this PR includes tests related to the intialization of the user range (ported from haskell).
The test for the user range widening has been moved to the http test module (together with other metrics) since it is unrelated to user registration.