Html5 semantics #731
Merged
Html5 semantics #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto html5-semantics
…-identity into html5-semantics
| @@ -139,7 +139,7 @@ const pageContent = (userNumber: bigint, devices: DeviceData[]) => html` | |||
| <label>Identity Anchor</label> | |||
| <div class="highlightBox">${userNumber}</div> | |||
| <div class="labelWithAction"> | |||
| <label class="labelAddedDevices" id="deviceLabel" | |||
| <label class="labelAddedDevices" class="deviceLabel" | |||
There was a problem hiding this comment.
Nit: I don't think there is any styling attached to the deviceLabel class. You could also just remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation : to improve user accessibility
Changes
Any banners, such as notification message that is shown on top during development or testing purpose, are given a
roleof banner. This is to account for any community users who rely on assistive technology.Color contrast: the "ADD NEW DEVICE" and "ADD RECOVERY MECHANISM" button text color was adjusted to have appropriate color contrast ratio of 4.5:1. Color differentiation is not apparent.
Icon Settings button given aria-label
During Copy of seed phrase, copy button changes to checked icon. Added title label.
Fix
deviceLabelchanged to class label, as id label only is for one unique element.