Remove --emulator selenium runs #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the --emulator flags are broken, because it does not actually use the emulator. To fix it, we would have to change the whole docker compose setup again to allow for unpredictable canister ids. Since the benefit of running the selenium tests on emulator is questionable anyway, I think the pragmatic solution is just to no longer run the --emulator selenium tests.
frederikrothenberger
force-pushed
the
frederik/no-emulator
branch
from
cdce6b2
to
b25bfc0
Compare
nmattia
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the --emulator flags are broken, because it does not actually use the emulator.
To fix it, we would have to change the whole docker compose setup again to allow for unpredictable canister ids.
Since the benefit of running the selenium tests on emulator is questionable anyway, I think the pragmatic solution is just to no longer run the --emulator selenium tests.