Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the test app in a separate CI step #738

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

frederikrothenberger
Copy link
Member

This allows building II and the test app in parallel cutting CI times by about 3 minutes.

This allows building II and the test app in parallel cutting CI times by about 3 minutes.
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just a comment being picky...

@@ -121,6 +121,34 @@ jobs:
exit 1
fi

test-app-build:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename to test-app-build-upload?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not, because it would make it inconsistent with docker-build.

@frederikrothenberger frederikrothenberger merged commit cfd43a5 into main Jul 12, 2022
@frederikrothenberger frederikrothenberger deleted the frederik/separate-test-app-build branch July 12, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants