Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to candid description in release #767

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Jul 25, 2022

We added the candid description as a released asset, however there were
two issues:

  • The (relative) path to the .did was incorrect,
  • The release script didn't support files outside of the top-level
    directory.

We added the candid description as a released asset, however there were
two issues:

* The (relative) path to the `.did` was incorrect,
* The release script didn't support files outside of the top-level
  directory.
@nmattia nmattia marked this pull request as ready for review July 25, 2022 08:57
@peterpeterparker peterpeterparker self-requested a review July 25, 2022 09:06
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@nmattia nmattia merged commit 6af46b8 into main Jul 25, 2022
@nmattia nmattia deleted the nm-fix-candid-path branch July 25, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants