submit button contained in form

[wackyleo459]

New Device Name screen:

Issue: When typing the device name, cannot submit by keyboard "enter" button

Resolution:

• Wrapped input and buttons within a form, enabling auto submit for key enter
• Fixed: Even when there was no name given, submit button would fire which resulted in an empty device name. Now if no text is given form will not be submitted.

[nmattia]

Thanks!

In other places in the codebase we preventDefault() when submitting the form. Is that necessary? Or can you just perform the action in onsubmit like you do here?

[wackyleo459]

Thanks!

In other places in the codebase we preventDefault() when submitting the form. Is that necessary? Or can you just perform the action in onsubmit like you do here?

We discussed it's safer to still include preventDefault(), although it works without because there is no actual html form data submission.

[nmattia]

Looking great, thanks!