Deploy to app #2728
Merged
Deploy to app #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation `idl2json` has a newer version that exposes the `--bytes-as hex` option. Additionally, the new version supports binstall, which is a standard installer for rust executables, so we can deprecate the custom installer (`dfxsoftware-idl2json-install`). # Changes - Update idl2json version - use binstall to install idl2json. # Tests See CI. Existing tests should suffice. --------- Co-authored-by: Max Murphy-Skvorzov <max@winning.black>
# Motivation In few workers we need to hold some values in worker memory as in #2639 in which we need to keep track of ICRC balances and transactions. That's why this PR introduces an ICRC store that can be use in worker. # Changes - new `IcrcWorkerStore` store - new package `worker-store` - add type for `IcrcAccountIdentifierText`, a `string`
This reverts commit ab51551.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The action that deploys to an app subnet works but is slow and not ergonomic.
Changes
Tests
See the CI runs. A sample run:
