Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workflow to update the aggregator #3738

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Nov 13, 2023

Motivation

We need to render SNS data accurately, so need to keep the aggregator SNS bindings up to date.

Changes

  • Add a bot to update the SNS aggregator bindings regularly.
    • Note: If the candid API has not changed, no new PR will be created.
    • Note: The code is largely identical to the bot that updates the proposals bindings and generally matches all the other update bots.

Tests

Todos

  • Add entry to changelog (if necessary).

@bitdivine bitdivine marked this pull request as ready for review November 14, 2023 12:18
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment

.github/workflows/update-aggregator.yml Outdated Show resolved Hide resolved
@bitdivine bitdivine added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 93ba0d3 Nov 14, 2023
48 checks passed
@bitdivine bitdivine deleted the update-aggregator branch November 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants