chore: update nodejs mobile to v18 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
commented
Feb 26, 2024
Comment on lines
+43
to
+44
| // We use NDK >= 24 due to NodeJS Mobile React Native | ||
| ndkVersion = "24.0.8215888" |
There was a problem hiding this comment.
I don't think this was strictly necessary since we don't really rely on the ndk for nodejs-mobile, but maybe better to keep here (i didn't try without this change)
| return `${name}-${version}-node-${NODE_ABI}-${target}.tar.gz`; | ||
| function getNodeJsMobileNodeVersions() { | ||
| const nodeVersionFilePath = new URL( | ||
| 'android/libnode/include/node/node_version.h', |
There was a problem hiding this comment.
this corresponds to the header file that the NodeJS project places several version-related constants in
ErikSin
approved these changes
Feb 27, 2024
EvanHahn
added a commit
to digidem/mapeo-map-server
that referenced
this pull request
Mar 4, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Mar 4, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Mar 4, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Mar 4, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/mapeo-sqlite-indexer
that referenced
this pull request
Mar 4, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/mapeo-map-server
that referenced
this pull request
Mar 4, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/mapeo-sqlite-indexer
that referenced
this pull request
Mar 13, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
EvanHahn
added a commit
to digidem/multi-core-indexer
that referenced
this pull request
Mar 13, 2024
This removes Node 16 support, given that (1) it is deprecated (2) it [is no longer used in CoMapeo][0]. [0]: digidem/comapeo-mobile#194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #171
Confirmation log via adb: