Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIE Integration #190

Closed
mpscholten opened this issue Jun 29, 2020 · 8 comments · Fixed by #244
Closed

HIE Integration #190

mpscholten opened this issue Jun 29, 2020 · 8 comments · Fixed by #244
Assignees

Comments

@mpscholten
Copy link
Member

Would be cool to have zero-setup support for Haskell Ide Engine out of the box

@sir4ur0n
Copy link
Contributor

Does this issue imply/also include Haskell Language Server? HLS is the converging point in terms of IDE experience, I think it would be best, what do you think?

@mpscholten
Copy link
Member Author

Yes :) the issues is a bit misnamed. The referenced PR is actually using HLS. We first tried HIE, but then changed the PR to work with HLS instead.

@mpscholten mpscholten assigned mpscholten and unassigned nezbite Jul 25, 2020
@sir4ur0n
Copy link
Contributor

Awesome, thank you @mpscholten !

@Montmorency
Copy link
Contributor

Was working on integrating hls with vim for IHP projects today. I think this issue 614 might be a fix for the template haskell issue raised here. I tried building hls with the fix-more-th branch of ghcide but kept ran in to a bit of trouble compiling. However as soon as that patch makes it into the master branch of ghcide I think that will resolve this issue with HLS/IHP. So maybe one to watch?

@mpscholten
Copy link
Member Author

Thanks for pointing out. Just subscribed to that PR :) Once it's merged we can continue the integration

@mpscholten
Copy link
Member Author

It looks like the fix for this just got merged via haskell/ghcide#741 :) This means we can continue the work on this now 👍

@maralorn
Copy link

Please be aware, that https://github.com/digital-asset/ghcide/issues/614 is still open. Because there still are issues with TH sometimes. I am not aware of what issue exactly you are having, so I don‘t know if the merged fix helps you or not.

@mpscholten
Copy link
Member Author

Thanks for letting us know 👍 I think our issue is mostly related to symbols need to be exported because they occur in a TH splice.. Will try out to build the fixed version tomorrow, maybe we're lucky and everything is working already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants