Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discover view: Opening a mood reveals a favorite button that doesn't save anyting #120

Open
vali3841 opened this issue Mar 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@vali3841
Copy link

Describe the bug
Opening any mood will reveal a favorite button in the upper right that does not save in any of the favorites button. Reloading the page and opening the same mood will not show the favorite button as "enabled". pressing the favorite button will return a server 500

To Reproduce

  1. Open the mood view
  2. Pick a mood
  3. Press on the favorite button

Expected behavior
I'm not really sure, maybe the button shouldn't exist for moods? OR if you plan to make many many more moods, maybe a new category of "favorite moods" needs to be implemented in the Favorites view

Additional context
The request that returns 500 when pressing the favorite button is:
https://next.openbroadcast.ch/api/v1/rating/catalog.mood:A47C4528/ (the A47C4528 will probably be specific to the mood)

environment:
firefox on mac m1

@vali3841 vali3841 added the bug Something isn't working label Mar 29, 2023
@ohrstrom
Copy link
Member

@vali3841 500 error is gone ;).
not obvious - i agree. currently the only effect when adding a mood as "favourite" is that it get's marked in the overview:

it also shows the "liked" moods first, but currently only after a reload.
the reload/reorder is planned to happen automatically - and the layout for the page will change a bit:

then it could be useful to have the favourite moods displayed first..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants