Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new release (dev build points to /ws that doesn't include a fix) #10304

Closed
Danielduel opened this issue May 29, 2024 · 3 comments
Closed

Comments

@Danielduel
Copy link

Danielduel commented May 29, 2024

Which package is this bug report for?

discord.js

Issue description

Dev release of discordjs (discord.js@14.15.3-dev.1716768610-d22b55fc8) points to @discordjs/ws@1.1.0 instead of @discordjs/ws@2.0.0-dev.1716768608-d22b55fc8 (most likely it's intended, but it would fix my problem).
@discordjs/ws@1.1.0 doesn't include fix for invalid protocol value fixed in #10271
I can go around this problem locally, but it's very problematic for "serverless" functions running on deno to go around this problem :/
I am not aware of the current scope for the next release, but I would like to ask for a bugfix publish-release which contains previously-mentioned PR with bumped-up versions

Code sample

No response

Versions

As described above

Issue priority

Medium (should be fixed soon)

Which partials do you have configured?

Not applicable

Which gateway intents are you subscribing to?

Not applicable

I have tested this issue on a development release

No response

@Danielduel Danielduel changed the title Publish a new release Publish a new release (dev build points to /ws that doesn't include a fix) May 29, 2024
@Jiralite
Copy link
Member

This will be a breaking change in discord.js, so it will not happen soon, if anything.

@Jiralite Jiralite closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
@Danielduel
Copy link
Author

Thank you for the quick response!

@Jiralite
Copy link
Member

Jiralite commented Jun 2, 2024

https://github.com/discordjs/discord.js/releases/tag/14.15.3 includes the compatibility fix for Deno users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants