Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: use readonly array / collection types for user input #10045

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Dec 10, 2023

Please describe the changes this PR makes and why it should be merged:
Added an ESLint rule to enforce the use of readonly Array and Collection types in function/method parameters and interface properties

Status and versioning classification:

@almeidx almeidx requested a review from a team as a code owner December 10, 2023 17:56
Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 0:27am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 0:27am

@Jiralite
Copy link
Member

Jiralite commented Dec 10, 2023

Is there one for const type parameters? Also, shouldn't we enforce these changes to all packages?

@almeidx almeidx force-pushed the types/readonly-array branch 2 times, most recently from 6b2c2bc to 6ab7685 Compare December 24, 2023 18:10
@Jiralite Jiralite added this to the discord.js 14.15 milestone Feb 3, 2024
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't break user code

@vladfrangu
Copy link
Member

Also this needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants