Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): resolve linkTags in meta description #10088

Merged
merged 6 commits into from
Feb 3, 2024

Conversation

brynpttrsn
Copy link
Contributor

@brynpttrsn brynpttrsn commented Jan 14, 2024

Please describe the changes this PR makes and why it should be merged:

Resolves LinkTagNodes in meta description. Fixes djs links, dapi links, and uses linkText when applicable.

GuildChannel
image
image

MentionableSelectMenuInteraction
image
image

version
image
image

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 10:08pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 10:08pm

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f691658) 58.53% compared to head (886d00c) 57.97%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10088      +/-   ##
==========================================
- Coverage   58.53%   57.97%   -0.56%     
==========================================
  Files         244      242       -2     
  Lines       17267    17027     -240     
  Branches     1244     1231      -13     
==========================================
- Hits        10107     9872     -235     
+ Misses       7115     7110       -5     
  Partials       45       45              
Flag Coverage Δ
utilities 100.00% <ø> (ø)
website 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almeidx almeidx requested review from Qjuh and removed request for almeidx January 17, 2024 12:09
packages/scripts/src/generateIndex.ts Outdated Show resolved Hide resolved
packages/scripts/src/generateIndex.ts Outdated Show resolved Hide resolved
@brynpttrsn brynpttrsn changed the title fix(website): resolve linkTags in summaries fix(website): resolve linkTags in meta description Jan 18, 2024
@brynpttrsn brynpttrsn requested a review from Qjuh January 18, 2024 02:57
@kodiakhq kodiakhq bot merged commit 56943a7 into discordjs:main Feb 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants