Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update husky to v9 #10102

Merged
merged 6 commits into from
Feb 3, 2024

Conversation

vinayakkulkarni
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • This PR includes non-code changes, mostly affects improved DX.

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 9:58pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 9:58pm

@iCrawl iCrawl added the blocked label Jan 26, 2024
.husky/commit-msg Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Jiralite Jiralite changed the title chore(dev-deps): migrate to husky v9 🐶 build: Update husky to v9 Jan 26, 2024
Copy link
Contributor

@sdanialraza sdanialraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almostSouji
almostSouji previously approved these changes Jan 26, 2024
@vinayakkulkarni
Copy link
Contributor Author

Looking at the husky release v9.0.1, can vinayakkulkarni/discord.js@9bf20c6/package.json#L22 be changed from is-ci || husky install to is-ci || husky?

@almostSouji almostSouji dismissed their stale review January 27, 2024 15:34

resolved raised issue in package information, considerations and correctness are scope of core maint.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f691658) 58.53% compared to head (7caaf7d) 58.57%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10102      +/-   ##
==========================================
+ Coverage   58.53%   58.57%   +0.03%     
==========================================
  Files         244      244              
  Lines       17267    17309      +42     
  Branches     1244     1250       +6     
==========================================
+ Hits        10107    10138      +31     
- Misses       7115     7126      +11     
  Partials       45       45              
Flag Coverage Δ
brokers 63.49% <ø> (ø)
builders 95.56% <ø> (ø)
collection 99.32% <ø> (ø)
formatters 99.31% <ø> (ø)
guide 0.00% <ø> (ø)
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.58% <ø> (-0.33%) ⬇️
util 70.70% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.64% <ø> (ø)
website 0.00% <ø> (ø)
ws 52.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iCrawl iCrawl removed the blocked label Feb 3, 2024
@kodiakhq kodiakhq bot merged commit 9f8d7fe into discordjs:main Feb 3, 2024
22 checks passed
@vinayakkulkarni vinayakkulkarni deleted the chore/upgrade-husky-v9 branch February 7, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants