Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): always link in TypeAlias #10105

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Jan 28, 2024

Please describe the changes this PR makes and why it should be merged:

Previously only (most) Union types had links to their members. This now adds linked Excerpts for all TypeAliases.

Also fixes an issue with markdown lists in JSDoc not being shown in the generated TSDoc in api-extractor.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 10:14pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 10:14pm

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (56943a7) 58.53% compared to head (b4978c3) 58.59%.

Files Patch % Lines
apps/website/src/components/model/TypeAlias.tsx 0.00% 3 Missing ⚠️
...bsite/src/components/documentation/tsdoc/TSDoc.tsx 0.00% 2 Missing ⚠️
...ents/documentation/section/UnionMembersSection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10105      +/-   ##
==========================================
+ Coverage   58.53%   58.59%   +0.05%     
==========================================
  Files         244      244              
  Lines       17267    17303      +36     
  Branches     1244     1250       +6     
==========================================
+ Hits        10107    10138      +31     
- Misses       7115     7120       +5     
  Partials       45       45              
Flag Coverage Δ
brokers 63.49% <ø> (ø)
builders 95.56% <ø> (ø)
collection 99.32% <ø> (ø)
formatters 99.31% <ø> (ø)
next ∅ <ø> (∅)
proxy 75.00% <ø> (ø)
rest 92.58% <ø> (-0.33%) ⬇️
util 70.70% <ø> (ø)
voice 63.64% <ø> (ø)
website 0.00% <0.00%> (ø)
ws 52.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit bc9b487 into discordjs:main Feb 4, 2024
22 checks passed
@Qjuh Qjuh deleted the website/type-alias branch March 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants