Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): use correct version for cross-package links #10193

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Mar 26, 2024

Please describe the changes this PR makes and why it should be merged:

Links to types in other subpackages use the correct version of that subpackage now, instead of the version of the current package.

Fixes for example https://discord.js.org/docs/packages/discord.js/14.14.1/Client:Class#rest

Also fixed two small issues for local testing of the docs website

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Qjuh Qjuh requested a review from a team as a code owner March 26, 2024 00:21
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 0:22am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 0:22am

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 61.97%. Comparing base (a1a3a95) to head (6544c29).

Files Patch % Lines
apps/website/src/util/fetchNode.ts 0.00% 4 Missing ⚠️
apps/website/src/components/DocNode.tsx 0.00% 1 Missing ⚠️
apps/website/src/components/ExcerptNode.tsx 0.00% 1 Missing ⚠️
apps/website/src/util/fetchSitemap.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10193      +/-   ##
==========================================
- Coverage   62.35%   61.97%   -0.39%     
==========================================
  Files         209      210       +1     
  Lines       16280    16382     +102     
  Branches     1213     1214       +1     
==========================================
  Hits        10152    10152              
- Misses       6083     6185     +102     
  Partials       45       45              
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iCrawl iCrawl merged commit afb97fb into discordjs:main Apr 11, 2024
22 checks passed
@Qjuh Qjuh deleted the website/cross-package-version branch April 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants