Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(TextInputBuilder): correct constructor documentation #10308

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

CodeGoat-dev
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Fixes incorrect references to select menu options in text input docs.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Fixes incorrect references to select menu options in text input docs.
@CodeGoat-dev CodeGoat-dev requested a review from a team as a code owner May 31, 2024 18:38
Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2024 0:35am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2024 0:35am

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (38a37b5) to head (dd887d4).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10308       +/-   ##
===========================================
+ Coverage   64.36%   92.33%   +27.97%     
===========================================
  Files           4       48       +44     
  Lines         463     4097     +3634     
  Branches        0      283      +283     
===========================================
+ Hits          298     3783     +3485     
- Misses        165      314      +149     
Flag Coverage Δ
brokers 95.89% <100.00%> (+31.53%) ⬆️
builders 95.89% <100.00%> (+31.53%) ⬆️
collection 95.89% <100.00%> (+31.53%) ⬆️
discord.js 95.89% <100.00%> (+31.53%) ⬆️
formatters 95.89% <100.00%> (+31.53%) ⬆️
guide 95.89% <100.00%> (+31.53%) ⬆️
next 95.89% <100.00%> (+31.53%) ⬆️
proxy 95.89% <100.00%> (+31.53%) ⬆️
rest 95.89% <100.00%> (+31.53%) ⬆️
utilities 95.89% <100.00%> (+31.53%) ⬆️
voice 95.89% <100.00%> (+31.53%) ⬆️
website 95.89% <100.00%> (+31.53%) ⬆️
ws 95.89% <100.00%> (+31.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite changed the title feat(builders): fix text input docs docs(TextInputBuilder): correct constructor documentation May 31, 2024
@Jiralite Jiralite added this to the builders 1.8.2 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants