Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate client options presence #10419

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

didinele
Copy link
Member

No description provided.

@didinele didinele requested a review from a team as a code owner July 31, 2024 07:57
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ❌ Failed (Inspect) Aug 1, 2024 10:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2024 10:48am

@kyranet
Copy link
Member

kyranet commented Jul 31, 2024

One little thing, you should mark this field as deprecated in the typings:

presence?: PresenceData;

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to the PR so the typing change is applied

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/client/Client.js Outdated Show resolved Hide resolved
Co-authored-by: Almeida <almeidx@pm.me>
@didinele didinele force-pushed the deprecate/client-options-presence branch from 91f79f4 to 7c8dd2b Compare July 31, 2024 11:14
@kodiakhq kodiakhq bot merged commit 8f97d2b into main Jul 31, 2024
7 of 8 checks passed
@kodiakhq kodiakhq bot deleted the deprecate/client-options-presence branch July 31, 2024 11:20
almeidx added a commit that referenced this pull request Aug 4, 2024
kodiakhq bot pushed a commit that referenced this pull request Aug 6, 2024
Revert "chore: deprecate client options presence (#10419)"

This reverts commit 8f97d2b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants