-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: chore: deprecate client options presence #10426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
force-pushed
the
fix/ws-presence-validation
branch
from
August 4, 2024 02:03
b3c860e
to
6c198fe
Compare
didinele
approved these changes
Aug 4, 2024
kyranet
approved these changes
Aug 4, 2024
Qjuh
suggested changes
Aug 4, 2024
vladfrangu
previously requested changes
Aug 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes too in case Qjuhs doesn't count
almeidx
force-pushed
the
fix/ws-presence-validation
branch
from
August 4, 2024 12:22
6c198fe
to
9e68f34
Compare
almeidx
changed the title
fix: ws
refactor: rename Aug 4, 2024
presence
validationws.presence
option to ws.initialPresence
This reverts commit 8f97d2b.
almeidx
force-pushed
the
fix/ws-presence-validation
branch
from
August 4, 2024 14:23
9e68f34
to
00cfef1
Compare
almeidx
changed the title
refactor: rename
revert: chore: deprecate client options presence
Aug 4, 2024
ws.presence
option to ws.initialPresence
didinele
approved these changes
Aug 4, 2024
vladfrangu
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f97d2b.
After internal discussion, we decided to revert this change. See #10426 (comment) for more info