Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: chore: deprecate client options presence #10426

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 4, 2024

This reverts commit 8f97d2b.

After internal discussion, we decided to revert this change. See #10426 (comment) for more info

@almeidx almeidx requested a review from a team as a code owner August 4, 2024 01:36
Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2024 2:23pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2024 2:23pm

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/util/Options.js Outdated Show resolved Hide resolved
packages/discord.js/src/client/Client.js Outdated Show resolved Hide resolved
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes too in case Qjuhs doesn't count

@almeidx almeidx changed the title fix: ws presence validation refactor: rename ws.presence option to ws.initialPresence Aug 4, 2024
@almeidx almeidx changed the title refactor: rename ws.presence option to ws.initialPresence revert: chore: deprecate client options presence Aug 4, 2024
@almeidx almeidx added this to the discord.js 14.16 milestone Aug 6, 2024
@kodiakhq kodiakhq bot merged commit 5c90b7f into main Aug 6, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the fix/ws-presence-validation branch August 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants