New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(GuildMember): make `_roles` property non-enumerable #9387

Merged

kodiakhq merged 8 commits into discordjs:main from Idris1401:refactor/guildmember-_roles

May 18, 2023

packages/discord.js/src/structures/GuildMember.js

-Original file line number
+Diff line change
@@ Expand Up / @@ -56,10 +56,12 @@ class GuildMember extends Base { @@
         /**
          * The role ids of the member
+         * @name GuildMember#_roles
          * @type {Snowflake[]}
          * @private
          */
-        this._roles = [];
+        Object.defineProperty(this, '_roles', { value: [] });
         if (data) this._patch(data);
       }
@@ Expand Down @@