-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Deprecate step after publish & standalone file #9837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-ci-deprecate-discordjs.vercel.app/ |
Running Lighthouse audit... |
Jiralite
force-pushed
the
ci/deprecate
branch
from
September 17, 2023 09:25
4022bfc
to
5ccc422
Compare
SpaceEEC
approved these changes
Sep 17, 2023
vladfrangu
approved these changes
Sep 17, 2023
kyranet
approved these changes
Sep 18, 2023
iCrawl
approved these changes
Sep 19, 2023
almeidx
pushed a commit
to almeidx/discord.js
that referenced
this pull request
Sep 24, 2023
* ci: deprecate step after publish & standalone file * docs: update contributing file --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Publishing development versions run twice daily. Deprecating packages run once daily. As a result of this, there will be two development versions not deprecated at a time for about an hour according to the times.
Deprecating prior development releases as soon as a new version is published seems ideal. This made the npm auto deprecate workflow redundant, so I've remade it into something that may be manually run by those with write access.
Status and versioning classification: