Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant edge in "Graph Attention Networks" figure #23

Open
agamemnonc opened this issue Mar 5, 2023 · 0 comments
Open

Redundant edge in "Graph Attention Networks" figure #23

agamemnonc opened this issue Mar 5, 2023 · 0 comments

Comments

@agamemnonc
Copy link

This issue refers to this figure.

I believe that the edge between the yellow "key" node and the very light grey node should not be there, as in this case the light grey node should also be a query node and used for computing a pairwise score with the query node.

Btw, congratulations for the excellent article! By far the best introductory resource on GNNs I have come across, thank you for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant