Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Executor Prometheus metrics: calculating % of failed jobs should be easy #1570

Open
atmosx opened this issue Aug 28, 2024 · 0 comments

Comments

@atmosx
Copy link
Contributor

atmosx commented Aug 28, 2024

Is your feature request related to a problem? Please describe.

I’m trying to create a Grafana dashboard based on the shell executor metrics. One of the graphs is meant to calculate the percentage of failed jobs over a specific time frame or from the start of tracking.

The dkron_job_execution_done_count metric is a counter. A common approach is to filter by a specific label versus all entries of the same metric. This can be achieved by adding exit_code as a label to dkron_job_execution_done_count. Since it’s a low cardinality metric, adding this label should not pose any issues.

Describe the solution you'd like
Add exit_code to dkron_job_execution_done_count.

Describe alternatives you've considered
None.

@atmosx atmosx changed the title Shell Executor Prometheus metrics Shell Executor Prometheus metrics: calculate % of failed jobs should be easy Aug 28, 2024
@atmosx atmosx changed the title Shell Executor Prometheus metrics: calculate % of failed jobs should be easy Shell Executor Prometheus metrics: calculating % of failed jobs should be easy Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants