Patch 1 #6
Closed
Patch 1 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the application's palette color for links to the shade of blue from gridcoin-community#847. It improves the visibility of links when using the dark mode.
This sets the "Fusion" Qt theme as the application's base style for Windows and macOS to normalize some minor appearance issues between different platforms. Fusion is the default style used for Linux for desktops without a custom window manager theme. From what I read, the Windows theme still has some high-DPI issues, and the Fusion styles support high-DPI displays very well.
Nobody asked for it but I did it anyway. Don't know if this will have implication on Testnet if the added nodes don't run Testnet. Added new nodes and removed dead ones where the hostname resolution failed according to https://addnode.cycy.me
…used_rpcs rpc: Remove deprecated RPC commands
…color gui: Fix dark theme link text color visibility
…style gui: Set standard base Qt style on Windows and macOS
1. Changes the (un)select all button to a true select all/select none filp-flop. 2. Implements an input filter function to allow the selection of inputs either less than or equal to or greater than or equal to a provided input value. This can be used for more than just consolidations. 3. Implements a "Consolidate" button which limits the selected inputs to 600 to ensure the consolidation transaction will be successful, presents a pick list to select the destination address for the consolidation, and then automatically fills in the send transaction for convenience.
…idate_unspent gui: Implement GUI version of consolidateunspent (coin control part)
build, refactor: bump to C++17
This implements a chain parameter function to get the maximum number of inputs allowable for a UTXO consolidation transaction with either the RPC consolidateunspent or the GUI "consolidate" button in coin control. The default value for the RPC consolidateunspent function has been changed to be the same as the upper clamp at the value returned by GetMaxInputsForConsolidationTxn(). The help returned for consolidateunspent uses that value as well.
This removes the standard menu bar from the main application layout in favor of a menu button placed at the top-left corner of the window. It enables the visual style of the proposed GUI designs which do not have a menu bar. The menu button does not appear on macOS because the macOS standard menu bar at the top of the screen already separates the menus from the main layout.
This replaces the "error messages" field on the overview page with a section in the status bar to match the proposed GUI design.
This updates the overview page to match the appearance from the proposed GUI design. - Add a header bar with status, magnitude, and available balance - Split content sections into cards - Change out of sync and researcher action needed labels to badges - Change beacon button to an icon - Limit the max content width for large window sizes - Update colors, layout, sizing, and spacing
This changes the text for the following phrases on the overview page: - the "Recent transactions" label to "Recent Transactions" - the "out of sync" label to "Out of Sync" - the "Current Poll:" label to "Current Polls" ...and updates the localization metadata keys. Because the meanings of the phrases did not change, this preserves the existing translations for those entries.
This adds a button next to the logo in the sidebar that switches the active GUI theme between light and dark mode.
…nsolidateunspent_max_inputs util, rpc, gui: Implement GetMaxInputsForConsolidationTxn()
gui: Refresh overview page design
…rror depends: change boost mirror
wallet: remove dead hardcoded addnodes
This implements a three step wizard that leads the user through the process of selecting inputs, selecting a destination, and then reviewing the overall transaction. Select Inputs: The select inputs screen uses similar code to that in coincontroldialog to support the consolidate button there. Pointers to the coincontrol data structures constructed in sendcoinsdialog are passed into both coincontrol and the consolidateunspentwizard to faciliate using the underlying machinery in a unified manner. This is possible because both coincontrol and consolidateunspendwizard are called with the sendcoinsdialog and are modal. Note that there is a stop sign and the next button is disabled if more than 600 outputs are selected. The next button is also disabled if less than 2 outputs are selected (as it makes no sense to consolidate when there is no consolidation achievable based on the selection). If a filter operation is applied based on the filter criteria, and that criteria would result in more than 600 inputs being selected, the selection is reduced to 600 inputs and a warning triangle is presented. Select Destination Address: If all of the inputs selected in the prior page are from one address, then that address will already be preselected (but allow the opportunity for it to be changed by the user prior to pressing next). If the inputs selected correspond to more than one address, an address will NOT be pre-selected, and the user will be required to pick an address to proceed. The next button will be disabled until a valid address is selected for the destination. Confirmation: The final screen presents the details of the intended transaction for review by the user. When the "Finish" button is pressed, the transaction to send is filled in in the send dialog sreen, and the user can review the details again if desired and press the send button to send.
This corrects the mapping of change to the CoinControlChangeLabel field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.