Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<AutocompleteElement> storybook's "Pre Select" cases needs to clarify where values come from #304

Open
2 tasks done
Skarvion opened this issue Sep 2, 2024 · 1 comment

Comments

@Skarvion
Copy link

Skarvion commented Sep 2, 2024

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Took me a long time to understand that the default values of a field are provided at the form container level. Reading through the storybook documentation, it doesn't make it clear it's populated at the form level.

The stories should contain <FormContainer> too or at the very least a comment explaining that the default values are added there. Probably can add a paragraph element using this https://storybook.js.org/docs/writing-stories/decorators#context-for-mocking

If you'd like to, I can try to raise a PR to go for the second option.

Examples 🌈

No response

@dohomi
Copy link
Owner

dohomi commented Sep 2, 2024

Hi @Skarvion sure if you have time I am happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants