Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llvm mingw #1173

Merged
merged 2 commits into from Aug 26, 2019
Merged

Llvm mingw #1173

merged 2 commits into from Aug 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2019

Fixes for compilation with llvm-mingw:
https://github.com/mstorsjo/llvm-mingw

When using libstdc++, it's somehow implicitly included, but it's not the case for libc++.
…pported before using it.

lld-link linker does not support nor need it.
@doitsujin doitsujin merged commit e7b7192 into doitsujin:master Aug 26, 2019
@pchome
Copy link
Contributor

pchome commented Aug 26, 2019

Maybe better use separate cross-files? More freedom to unconditionally set compiler binary names (cpp = 'i686-w64-mingw32-clang++' ?) and compiler flags.

@ghost
Copy link
Author

ghost commented Aug 27, 2019

I don't see how it would be better. In my opinion, build system should be able to figure it out instead of hardcoding every possible configuration.

@ghost ghost deleted the llvm-mingw branch August 27, 2019 08:00
@pchome
Copy link
Contributor

pchome commented Aug 27, 2019

Sure, it completely on developers how to configure their project's build system, but in theory in such cross-files we configuring build environment only once. Then we should be able to build every similar project using the same cross-file, w/o any modification to build system. Those files even not needed to be a part of the project (meson can find them in ~/.local/share/meson/cross/ or /usr/share/meson/cross/).

In real world we have multiple similar projects with copy-pasted cross-files and meson.build. Many of them (projects) took DXVK's build system as template, and now they may feel like they should adjust their build systems in the similar way for llvm-mingw, but they shouldn't (IMHO).

I personally would like to see this cross-files as a hint, to be moved in separate directory and extended with "debug" variants, even if I use completely different variant locally.

Anyway, not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants