[util] Disable direct buffer mapping for Dragon Age Origins #3023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3022
I would still like to just get rid of direct buffer mapping because it causes nothing but problems.
Also, curiously I've tried calling Lock(0) and then Lock(DISCARD) a bunch of times on a POOL_DEFAULT + USAGE_WRITEONLY | USAGE_DYNAMIC buffer on Windows and I got the same pointer every time.
So either it straight up ignores DISCARD or it does some tracking whether the buffer is currently in use on the GPU.
We could of course also do that but I would rather not synchronize with the CS thread for every Lock(DISCARD) call.
So this is the solution for now.
Disabling direct buffer mapping makes it ignore DISCARD and go through the staging buffer upload path.
We recently added a memory limit to that which saves the day for Dragon Age Origins.