Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine install script to support overrides only. #57

Merged
merged 2 commits into from
Feb 5, 2018

Conversation

Raffarti
Copy link
Contributor

@Raffarti Raffarti commented Feb 3, 2018

Only overrides supported. #56
Possible developments:

  • report former status instead of forcing everything to help diagnostic, maybe add check only option;
  • renaming the script (I would keep dlls in the name to avoid it being mistaken for a system wide setup);
  • add an option to copy dlls rather than link them.

removeOverride d3d11
echo -n '[2/2] '
removeOverride dxgi
exit
fi
Copy link
Owner

@doitsujin doitsujin Feb 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason you're not simply using an else here instead of that exit; fi construct? This would make the script easier to read in my opinion, although this of course won't stop me from merging the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really, just a stylistic choice. It doesn't feel natural to have the main code in a else statement. This way it's clearer that the reset option is the alt case, and the other is the main purpose of the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants