Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support typed children in TSX #43

Closed
agubler opened this issue Jul 30, 2018 · 0 comments · Fixed by #544
Closed

Support typed children in TSX #43

agubler opened this issue Jul 30, 2018 · 0 comments · Fixed by #544
Labels
enhancement New feature or request

Comments

@agubler
Copy link
Member

agubler commented Jul 30, 2018

@matt-gadd commented on Wed Sep 13 2017

Enhancement

TypeScript now supports typed children in TSX, we need to update our JSX namespace to leverage it by adding the ElementChildrenAttribute.

@matt-gadd commented on Tue Jun 05 2018

Okay this doesn't currently work due to ElementChildrenAttribute looking on the ElementAttributesProperty, which in our case is properties. See microsoft/TypeScript#18357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typed children for function-based widgets agubler/framework
1 participant
@agubler