Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with @types to publish parts of this repo versus DefinitelyTyped #39

Closed
kitsonk opened this issue Sep 19, 2016 · 4 comments
Closed

Comments

@kitsonk
Copy link
Member

kitsonk commented Sep 19, 2016

We should work with the team @types to be able to leverage the parts of this repo to package up and replace what is currently being published to the @types namespace for the projects that are part of the Dojo Toolkit (e.g. @types/dojo).

@dylans
Copy link
Member

dylans commented Oct 7, 2016

This should be easier to achieve once microsoft/types-publisher#4 is solved.

@HeikoStudt
Copy link
Contributor

Ping: That issue is like 4 years old and seems not to be solved in the near future, though.
There is a real issue for us currently, as @types/dojo does have some wrong types, while e.g. dojo-dstore is referencing @types/dojo.

We are not sure whether to contribute fixes to either @types/dojo or here, both look like to be somewhat half-maintained.

@dylans
Copy link
Member

dylans commented Sep 21, 2020

Hi @HeikoStudt, thanks for the feedback and PRs here and in dstore. This package is maintained more in my opinion, mostly as people like you suggest changes and improvements. We'll review your PRs asap. Please make sure you've approved the Contributor License Agreement (CLA) in at least one of the PRs so we can accept your contributions.

@HeikoStudt
Copy link
Contributor

Hi @dylans,
thanks a lot. Are there any plans to merge the two typings? Especially interesting are the generic/non-generic Deferred, where both variants are surely depended upon by a lot of existing code.
PS: I needed to put up new PRs for being able to sign - my apologies about that.

MFG (Kind Regards)

@kitsonk kitsonk closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants