-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to VS 2017 / v141 / SDK 10.0.16299.0 / Installer Redist 2017 #622
Comments
The VS2015-image runs Win 2012R2 (=8.1), the VS2017 one Win 2016 (=10). I think 10 and 7 are most common, but AppVeyor only provides those two images to free users. I think testing on 8.1 still provides value given that we don't test on Win7. All that is needed is replacing 2015 with 2017 and 2017 and 2015 in the config. I cannot remember why, but the order of images matters. So inside |
Thank you @Rondom , I have pushed my commit and revert the image config as you proposed 👍 Appveyor build: https://ci.appveyor.com/project/Maxhy/dokany/build/1.1.0-333 |
Ideally some of the companies using Dokany in commercial projects would sponsor some infrastructure to run it with different Windows versions. Windows 7, to avoid regressions and Windows 10 "trunk" (or whatever MS calls it) so that issues introduced by changes that MS does are caught early. We have now had two issues which were only noticed after some users upgraded and noticed things not working and I somehow doubt it will be the last Win10 update that changes something with regards to filesystems... |
@Liryna your message is bad, you're looking for VC++ 2017, not VC++ 2015. By the way, the binaries are here https://blogs.msdn.microsoft.com/chuckw/2017/08/14/visual-studio-2017-15-3-update/ (the installer fails to grab the right versions). |
Hi @KyleSanderson , You are right, I found that I forgot to change the VC++ version in the error message when it is not installed 👍 Thanks for the report ! |
WDK for VS 2017 has finally been released.
This makes use able to fully move to VS 2017 and new SDK.
Here is the current migration changes:
Liryna@5c9dbac
KB2999226 checks seems to no longer be needed since C++ 2015 Redistributable Update 3
"Microsoft Visual C++ 2015 Redistributable includes bug fixes to the runtime DLLs and also the latest versions for KB 2999226."
See https://www.microsoft.com/en-us/download/details.aspx?id=53587
ARM - VS 2017 need additional features enabled and a special flag on the cxproj to build ARM/ARM64.
See http://pete.akeo.ie/2017/05/compiling-desktop-arm-applications-with.html
@Rondom Appveyor has now the WDK installed in 2017 image that is needed to build. I have removed Visual Studio 2015 image of Appveyor.yml, The test were running in 2015 and 2017 image, does running in 2015 add something ? Another OS ? (I can revert the change.)
TODO:
The text was updated successfully, but these errors were encountered: