Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draco compression increases vertex count #1343

Closed
marwie opened this issue Apr 2, 2024 · 4 comments
Closed

Draco compression increases vertex count #1343

marwie opened this issue Apr 2, 2024 · 4 comments
Labels
bug Something isn't working external Problems or limitations traced back to other tools. package:extensions

Comments

@marwie
Copy link
Contributor

marwie commented Apr 2, 2024

Describe the bug
Hi, I'm not sure if this should be reported here or elsewhere and I'm geneally unsure why it happens in the first place but I have cases where applying draco compression increases the vertex count both for relatively lowpoly meshes as well as highpoly meshes.

To Reproduce
Steps to reproduce the behavior:

  1. Open zip and run gltf-transform draco sphere.glb sphere.draco.glb
  2. See vertex count changed from 515 to 519

Expected behavior
Vertex count doesn't change / doesn't increase

Versions:

  • Version: 3.10.1
  • Environment: node 20

Additional context

λ gltf-transform draco sphere.glb sphere.draco.glb --verbose
debug: dedup: Merged 0 of 6 accessors.
debug: dedup: Complete.
debug: weld: Complete.
debug: unpartition: Complete.
debug: [KHR_draco_mesh_compression] Compression options: {"method":1,"encodeSpeed":5,"decodeSpeed":5,"quantizationBits":{"POSITION":14,"NORMAL":10,"COLOR":8,"TEX_COORD":12,"GENERIC":12},"quantizationVolume":"mesh"}
debug: [KHR_draco_mesh_compression] Compressed 1 primitives.
info: sphere.glb (359.42 KB) → sphere.draco.glb (331.08 KB)

draco vertex count.zip

Before
image

After
image

@marwie marwie added the bug Something isn't working label Apr 2, 2024
@donmccurdy
Copy link
Owner

donmccurdy commented Apr 2, 2024

The v4 alpha has a new bit of information in the inspect() report, breaking out different ways of calculating a 'vertex count'. Interesting to note here that the number of vertices drawn are the same (i.e. same number of triangles), but the number in the vertex buffer is slightly larger.

Not sure I've found the right names for these yet, but:

before

renderVertexCount¹ gpuVertexCount² gpuNaiveVertexCount³
2,304 515 515

after

renderVertexCount¹ gpuVertexCount² gpuNaiveVertexCount³
2,304 519 519

¹ Expected number of vertices processed by the vertex shader for one render
pass, without considering the vertex cache.

² Expected number of vertices uploaded to GPU, assuming each Accessor
is uploaded only once. Actual number uploaded may be higher,
dependent on the implementation and vertex buffer layout.

³ Expected number of vertices uploaded to GPU, assuming each Primitive
is uploaded once, duplicating vertex attributes shared among Primitives.


If I switch from the 'edgebreaker' method to the 'sequential' method, the count does not increase, so I guess this must have something to do with how Draco is re-indexing the vertex stream for edgebreaker compression.

I have cases where applying draco compression increases the vertex count both for relatively lowpoly meshes as well as highpoly meshes.

In other cases has this been on the order of "a couple extra vertices", "+X% vertices", "+XX% vertices", etc.?

@donmccurdy donmccurdy added package:extensions needs investigation external Problems or limitations traced back to other tools. and removed bug Something isn't working labels Apr 2, 2024
@donmccurdy donmccurdy added this to the 🗄️ Backlog milestone Apr 2, 2024
@donmccurdy
Copy link
Owner

Small increase in vertex count appears to be an occasional effect of edgebreaker compression. Unsure if that's intended, but there seems to be nothing glTF Transform can do to prevent it.

@donmccurdy donmccurdy closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
@donmccurdy donmccurdy added bug Something isn't working and removed needs investigation labels Apr 14, 2024
@donmccurdy
Copy link
Owner

Ouch, this small increase in vertex count can cause the compressed mesh to overflow the max size of the index array type. Tracking in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Problems or limitations traced back to other tools. package:extensions
Projects
None yet
Development

No branches or pull requests

2 participants