-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draco compression increases vertex count #1343
Comments
The v4 alpha has a new bit of information in the inspect() report, breaking out different ways of calculating a 'vertex count'. Interesting to note here that the number of vertices drawn are the same (i.e. same number of triangles), but the number in the vertex buffer is slightly larger. Not sure I've found the right names for these yet, but: before
after
¹ Expected number of vertices processed by the vertex shader for one render ² Expected number of vertices uploaded to GPU, assuming each Accessor ³ Expected number of vertices uploaded to GPU, assuming each Primitive If I switch from the 'edgebreaker' method to the 'sequential' method, the count does not increase, so I guess this must have something to do with how Draco is re-indexing the vertex stream for edgebreaker compression.
In other cases has this been on the order of "a couple extra vertices", "+X% vertices", "+XX% vertices", etc.? |
Small increase in vertex count appears to be an occasional effect of edgebreaker compression. Unsure if that's intended, but there seems to be nothing glTF Transform can do to prevent it. |
Ouch, this small increase in vertex count can cause the compressed mesh to overflow the max size of the index array type. Tracking in: |
Describe the bug
Hi, I'm not sure if this should be reported here or elsewhere and I'm geneally unsure why it happens in the first place but I have cases where applying draco compression increases the vertex count both for relatively lowpoly meshes as well as highpoly meshes.
To Reproduce
Steps to reproduce the behavior:
gltf-transform draco sphere.glb sphere.draco.glb
Expected behavior
Vertex count doesn't change / doesn't increase
Versions:
Additional context
draco vertex count.zip
Before
After
The text was updated successfully, but these errors were encountered: