You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Hi all,
In case when items list will be empty - Status will be set to 'NotFound', but then the value will be written to 'Ok'. Seems it's wrong behavior. If yes - PR has been created.
The text was updated successfully, but these errors were encountered:
Hi @dmytrohridin, thank you for pointing that out. Yes, that's definitely a scope of improvement.
As the client await GrpcCallerService.CallService( relying on return this.MapToResponse( statement that's the reason it's not doing any check on ServerCallContext status. The correct status is useful for the unit test and for the client as well.
Looks good. Accepting the PR and closing the issue.
Hi all,
In case when items list will be empty - Status will be set to 'NotFound', but then the value will be written to 'Ok'. Seems it's wrong behavior. If yes - PR has been created.
The text was updated successfully, but these errors were encountered: