Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

CatalogService: GetItemsByIds wrong behavior #1303

Closed
dmytrohridin opened this issue Apr 18, 2020 · 2 comments
Closed

CatalogService: GetItemsByIds wrong behavior #1303

dmytrohridin opened this issue Apr 18, 2020 · 2 comments

Comments

@dmytrohridin
Copy link
Contributor

Hi all,
In case when items list will be empty - Status will be set to 'NotFound', but then the value will be written to 'Ok'. Seems it's wrong behavior. If yes - PR has been created.
image

@dmytrohridin
Copy link
Contributor Author

Hello @mvelosop
Can I ask you to look at this issue? Seems it's a bug. If not - feel free to close it.
Thank you :)

@sughosneo
Copy link
Contributor

sughosneo commented Aug 20, 2020

Hi @dmytrohridin, thank you for pointing that out. Yes, that's definitely a scope of improvement.
As the client await GrpcCallerService.CallService( relying on return this.MapToResponse( statement that's the reason it's not doing any check on ServerCallContext status. The correct status is useful for the unit test and for the client as well.

Looks good. Accepting the PR and closing the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants